New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Selection edges do not impede flood fill. #823
Comments
Hi @oceanhahn! Flood fill should work as previous Aseprite versions by default (with |
Oh, I found what's happening. Attached are two screencaptures of flood-fill in action: the lefthand one shows a flood within a selection within a closed shape (behaving as expected): the fill only floods the interior space of the closed shape. The righthand figure shows a flood within a selection, within an open shape. When the flood evaluates which pixels to fill, it looks at the whole image and not just the pixels in the marquee. When it actually fills pixels, though, it only changes the ones in the selection. I would have expected it to stop flooding at the edge of the selection, rather than to compute every pixel and only alter the selected ones. 😗 Anyway, I don't know how hard that would be to fix, or if that's even what's going on. I hope this helps! :D The outcome I want is for fill to flood the middle section of the figure, as on the left, even if the whole figure is open beyond the selection area. (Of course, if there is a gap inside the selected area, flood-fill ought to still flood through it, filling all "visible" pixels -inside- the selection!) |
In short, it looks like it's flooding the unselected image, then applying just the selected portion to the view. It also looks like an old issue, since my legacy install of 0.9.5 does exactly the same thing! :0 |
Thanks for the great explanation! The selection should act like another edge for the flood fill. (I've checked Photoshop just out of curiosity and it works correctly 😄 ) |
I seem to remember old versions, as recently as 1.1, treating selection edges as barriers to flood filling, but this no longer seems to be so. Did this change intentionally in 1.1.0.1? It's a bit of a hassle to have to either outline the entire selection up to internal blockages (that is, a pattern of pixels that 'dams the flood')...
I've tried a number of things in an attempt to find the source of the problem (if indeed it is one)-- playing with 'contiguous' and 'stop at grid' -- nothing seems to solve it. Was this a deliberate change? If not, something's broken.
Thanks!
The text was updated successfully, but these errors were encountered: