Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the keyboard shortcuts dialog #777

Closed
ghost opened this issue Aug 22, 2015 · 7 comments
Closed

Improve the keyboard shortcuts dialog #777

ghost opened this issue Aug 22, 2015 · 7 comments
Assignees
@dacap
Labels
feature Feature request, or something should be improved
Milestone
v1.1

Comments

@ghost
Copy link

ghost commented Aug 22, 2015

the other day i was looking for a way to change the shortcuts for a couple of tools and at first i assumed there was no way to do that because i didn't notice that the section field is actually a combobox. so here's a mockup with better discoverability:

+-----------+-----------------------+
| Section 1    Section 1 shortcuts  |
+-----------+  ...                  |
| Section 2 |  ...                  |
+-----------+  ...                  |
| Section 3 |  ...                  |
+-----------+  ...                  |
| Section 4 |  ...                  |
+-----------+                       |
|           |                       |
|           |                       |
| +-------+ |                       |
| | Ok    | |                       |
| +-------+ |                       |
| +-------+ |                       |
| | Cancel| |                       |
| +-------+ |                       |
+-----------+-----------------------+
@dacap dacap added bug feature Feature request, or something should be improved labels Aug 22, 2015
@dacap dacap added this to the v1.1 milestone Aug 22, 2015
@dacap
Copy link
Member

dacap commented Aug 22, 2015

It's a good idea 👍

@dacap dacap removed the bug label Aug 22, 2015
@dacap dacap self-assigned this Aug 25, 2015
@dacap
Copy link
Member

dacap commented Aug 25, 2015

newkeyconf

@dacap dacap closed this as completed in 19951c6 Aug 25, 2015
@ghost
Copy link
Author

ghost commented Aug 25, 2015

i think the buttons should go in this order:

Import
Export
Reset
-------
Cancel
Ok

@dacap
Copy link
Member

dacap commented Aug 25, 2015

Sorry, I didn't think about it too well. Maybe in this way:

keyconf2

@Async0x42
Copy link

This last image looks good, with OK and Cancel on the bottom of the dialog

dacap added a commit that referenced this issue Aug 25, 2015
@dacap
Move OK/Cancel buttons at the bottom in Keyboard Shortcuts dialog
65baa8d 
Issue #777
@ghost
Copy link
Author

ghost commented Aug 25, 2015

another variant

7caafed0-4b4a-11e5-953b-567d312af103

@Async0x42
Copy link

Both are good, but I think this one causes a little too much white-space in the left box (since it's unlikely to be filled with categories I think), and the buttons being lower the the main list box causes the Reset button to draw my eye to it too much, so I prefer dacaps version. I'm not an artist though, just my personal thought!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dacap dacap

Labels
feature Feature request, or something should be improved
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@dacap @Async0x42