Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash/doesn't respond after several lock/unlocks of Windows session #436

Closed
aseprite-bot opened this issue Aug 20, 2014 · 5 comments
Closed

Crash/doesn't respond after several lock/unlocks of Windows session #436

aseprite-bot opened this issue Aug 20, 2014 · 5 comments
Labels
bug critical priority imported
Milestone
v1.0

Comments

@aseprite-bot
Copy link
Collaborator

From davidcapello on July 31, 2014 20:19:42

Reported here: https://twitter.com/JonKimbel/status/494985034810408960 I wasn't able to reproduce it yet.

Original issue: http://code.google.com/p/aseprite/issues/detail?id=436
@aseprite-bot aseprite-bot added this to the v1.0 milestone Aug 20, 2014
@aseprite-bot
Copy link
Collaborator Author

From davidcapello on July 31, 2014 16:21:40

Note for the developer: It could be related to Allegro library and DirectX issues when the device is lost

@aseprite-bot
Copy link
Collaborator Author

From helpimtr...@gmail.com on August 02, 2014 12:55:09

Recorded the issue using CamStudio: https://www.youtube.com/watch?v=POYCjH7FMTg CamStudio doesn't capture the Windows lock screen, so I added YouTube annotations to denote when the computer was locked - make sure annotations are enabled on your device!

@aseprite-bot
Copy link
Collaborator Author

From davidcapello on August 03, 2014 05:52:25

Status: Accepted

@aseprite-bot
Copy link
Collaborator Author

From davidcapello on August 03, 2014 06:21:30

Thanks for the video Jon. I was able to reproduce the issue (just leaving a running window for a long period of time).

Note for the developer:
IDirectDrawSurface2_Restore() call in restore_all_ddraw_surfaces() function returns a failed HRESULT = 0x8876024B (DDERR_WRONGMODE, can't restore all surfaces or this surface because it was created in a different mode)

aseprite/src/allegro/src/win/wddbmpl.c

Line 122 in ed6090b

hr = IDirectDrawSurface2_Restore(item->id);

@dacap
Copy link
Member

dacap commented Oct 26, 2014

We weren't able to reproduce the issue again, so I'll close this issue.

@dacap dacap closed this as completed Oct 26, 2014
@dacap dacap mentioned this issue Nov 2, 2014
Closed
dacap added a commit that referenced this issue Nov 2, 2014
@dacap
Fix #392 - Crash when another monitor is plugged in
13fc8e0 
When we change the number of monitors, we've to restore the primary
DirectDraw surface, but it cannot be just "restored", it must be
re-created.

Note: probably the real fix for #436 too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug critical priority imported
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@dacap @aseprite-bot