Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Bar Eats Hotkey Input #352

Closed
aseprite-bot opened this issue Aug 20, 2014 · 3 comments
Closed

Context Bar Eats Hotkey Input #352

aseprite-bot opened this issue Aug 20, 2014 · 3 comments

Comments

@aseprite-bot
Copy link
Collaborator

From kirby...@gmail.com on February 24, 2014 19:17:40

What steps will reproduce the problem? Case 1:

  1. Have pencil tool selected.
  2. Click the Pixel-perfect checkbox
  3. Press space, and try to pan the canvas.

Case 2:

  1. Have pencil tool selected.
  2. Click and drag the set brush size bar to set a brush size.
  3. Press q to attempt to select the lasso tool, or press 2 to attempt to zoom on the canvas. What is the expected output? What do you see instead? For case 1, I think it's probably safe to have that checkbox never accept keyboard input since it's just on/off and solely clicking to give it keyboard focus means the user has already changed the option and probably wouldn't need to change it back with a key press.

For case 2... how about if I click (and release) any bar that accepts number input, it clears the field. (Because if there's already something there, and I type... pretty much any number it will end up as 32 and then I have to backspace anyway.) Spacebar and potentially any other non number hotkey should make it lose focus. If I have typed nothing before this happens, the brush size will go back to what it was.

If I click (don't hold), the number field, then click the bar that sets the brush size the number input bar should similarly lose focus.

If I click and hold, then drag to set the brush size, the number bar should immediately lose focus. (because like case 1, one would figure I have already made the change I wanted from the mouse input given.) What version of the product are you using? On what operating system? Version-0.9.6-beta3 on Windows Vista 32bit

Original issue: http://code.google.com/p/aseprite/issues/detail?id=352

@aseprite-bot
Copy link
Collaborator Author

From kirby...@gmail.com on March 01, 2014 14:31:22

Related enough to put here. A lot of times I tried to draw, and no marks were made because my opacity was 0. I wondered how it kept getting set to 0. I figured it out, it's because just moving the mouse over any number input dialog gives it focus. So if my mouse drifted over opacity and I pressed space to pan, opacity got set to 0.

@aseprite-bot
Copy link
Collaborator Author

From davidcapello on March 02, 2014 19:13:23

Status: Accepted
Owner: davidcapello
Labels: -Priority-Medium Priority-High

@aseprite-bot
Copy link
Collaborator Author

From davidcapello on March 08, 2014 15:43:23

Fixed in some way. Commit: f107dd3 Changes:

  • Check-boxes in context bar don't capture keyboard focus.
  • About number fields 1) they lost focus after the slider is closed, 2) they don't get keyboard focus automatically on mouse over, 3) we have to click the field to focus it, 4) when we click the field the whole text is selected, so we can insert a new number, 5) only numbers are accepted in the field (other keys are propagated to parents, e.g. like spacebar)

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant