Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eyedropper tool changes in gui.xml not working #347

Closed
aseprite-bot opened this issue Aug 20, 2014 · 1 comment
Closed

Eyedropper tool changes in gui.xml not working #347

aseprite-bot opened this issue Aug 20, 2014 · 1 comment

Comments

@aseprite-bot
Copy link
Collaborator

From n.watso...@gmail.com on February 22, 2014 01:10:03

---What steps will reproduce the problem?

  1. Go to gui.xml and change:

to

tool id="pencil"
text="Pencil Tool"
ink_left="paint"
ink_right="pick_fg"
controller="freehand"
pointshape="pen"
intertwine="as_lines"
tracepolicy="accumulative"
/>

  1. Open the application and try right clicking with the pencil tool.
  2. Observe that the background color is changed.

---What is the expected output? What do you see instead?

Since I set ink_right to "pick_fg", it is expected that a right mouse click would change the current color used for drawing. I was trying to do this so I could select a color using right click, like in many other art software.

---What version of the product are you using? On what operating system?

I am using 0.9.5 on Windows 7.

--- I believe the bug is caused by these lines of code at line 225 in standby_state.cpp:

// Call the eyedropper command
if (clickedInk->isEyedropper()) {
Command* eyedropper_cmd =
CommandsModule::instance()->getCommandByName(CommandId::Eyedropper);

Params params;
params.set("target", msg->right() ? "background": "foreground");

UIContext::instance()->executeCommand(eyedropper_cmd, &params);
return true;

}

Rather than getting msg->right(), I think its supposed to be using the current Ink.

Original issue: http://code.google.com/p/aseprite/issues/detail?id=347

@aseprite-bot aseprite-bot added this to the v0.9 milestone Aug 20, 2014
@aseprite-bot
Copy link
Collaborator Author

From davidcapello on February 24, 2014 03:10:32

Thanks for this bug report. Fixed: 43b2be4

Status: Fixed
Owner: davidcapello
Labels: Milestone-0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant