Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Tag Properties 'From' and 'To' ignore custom frame count headers. #1350

Closed
oceanhahn opened this issue Dec 9, 2016 · 2 comments
Closed

Bug: Tag Properties 'From' and 'To' ignore custom frame count headers. #1350

oceanhahn opened this issue Dec 9, 2016 · 2 comments
Assignees
@dacap
Labels
bug
Milestone
v1.1

Comments

@oceanhahn
Copy link

oceanhahn commented Dec 9, 2016 •
edited

Was trying out the new custom frame count and discovered that UI frame numbers (which can show adjusted frame label numbers) are not consistent with the 'From' and 'To' fields in the Properties pane for tags (which still use the fixed frame count starting at one).

If you implemented the custom UI frame enumeration using an offset value, probably this value simply has not been applied to the values in the Tag Properties pane as well. :3

Thanks for looking into it!

Using ASEprite1.1.10 on Win7SP1.
(Related to #1300)
@oceanhahn
Copy link
Author

I poked around a little and my guess is that this new attribute docPref.timeline.firstFrame() should probably be applied to the from and to values in this line?

Hope that helps (and maybe it doesn't)!

@dacap dacap added the bug label Dec 11, 2016
@dacap dacap self-assigned this Dec 29, 2016
@dacap dacap added this to the v1.1 milestone Dec 29, 2016
@dacap dacap closed this as completed in a56dff5 Dec 29, 2016
@oceanhahn
Copy link
Author

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dacap dacap

Labels
bug
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@dacap @oceanhahn