Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cropping Data Outside the Canvas #1111

Closed
KasumiArai opened this issue May 4, 2016 · 5 comments
Closed

Cropping Data Outside the Canvas #1111

KasumiArai opened this issue May 4, 2016 · 5 comments
Assignees
Labels
feature Feature request, or something should be improved medium priority
Milestone

Comments

@KasumiArai
Copy link

KasumiArai commented May 4, 2016

Aseprite allows cels to be larger than the document's visible dimensions. It... is impossible to get rid of the stuff outside the window without involved workarounds.

I understand the want to preserve the unseen pixels in certain cases. But one of the realities of this is that if you say... have a large animated image that you crop, your file (and the data it's consuming) will not get smaller, ever (that I've found), for the life of the file for those frames. What I've done in the past is saved as .gif and reloaded, but this gets rid of my layers and things.

Here is an example (gif) of a situation where this problem was created:

newlevelformatwhy2
I started by cropping a 3840x2304 level map. I just checked the .ase and all of the original image is still there.

For the above I was able to use linked cels for the huge cropped image so it only occupied memory once, but for other scrolling demonstrations I've made, a huge image is there even after cropping in every frame.

I'm not sure adding a second option (called Crop Unseen(?)) is worth it. But maybe Crop with nothing selected could get rid of this unseen data instead of being grayed out?

Edit: Perhaps with a popup confirmation so the user can see what crop with nothing select is doing. If nothing is selected "Crop Non Visible Pixels? (Yes) (No)"

@dacap
Copy link
Member

dacap commented May 4, 2016

Known issue. Thanks for reporting this with so much details. Actually this issue will be even more visible in the next release where we can enable layer edges:
layer-edges

@dacap
Copy link
Member

dacap commented May 4, 2016

This issue is related to #559, after we edit a layer, we should automatically trim pixels.

@dacap dacap added this to the v1.1 milestone May 4, 2016
@dacap dacap self-assigned this May 4, 2016
@dacap dacap closed this as completed in 5d8af3c May 4, 2016
@dacap dacap reopened this May 4, 2016
@dacap dacap added feature Feature request, or something should be improved and removed bug high priority labels May 4, 2016
@dacap
Copy link
Member

dacap commented May 4, 2016

The commit 5d8af3c fixed the "buggy" part of this issue. Which means that now we can make files smaller manually erasing pixels (because cels will be get smaller and smaller). But there is no command to remove/crop all unseen areas automatically. That should be a new command.

@dacap
Copy link
Member

dacap commented May 12, 2016

This might be related to #804

@dacap
Copy link
Member

dacap commented Apr 22, 2019

I'll fix this issue adding a new option in the Canvas Size command:

image

So just using the Canvas Size with the same size, but with this option enabled, we will be able to remove the content outside the canvas.

@dacap dacap modified the milestones: v1.3, v1.2 Apr 23, 2019
@dacap dacap closed this as completed in e197a86 Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request, or something should be improved medium priority
Projects
None yet
Development

No branches or pull requests

2 participants